Openvpn compression and proxy support#315
Openvpn compression and proxy support#315stoutes wants to merge 5 commits intocachebag:dev-openvpnfrom
Conversation
…mports to crate root
|
@stoutes I'd presume the builder should/would mesh with that in some way. We'd want to reconcile the approach we made in #309 for Please also update your PR description as well to mention the issues you tackled directly. It looks like you're doing both #292 and #299. In the future, I'd prefer you keep a PR to one issue, unless they're related in some fashion. (#288 is just the tracking issue for OpenVPN support so I wouldn't call them related). Lastly, HUGE nitpick, but your commit messages should be |
Summary
Part of #288, closes #292, closes #299.
Adds OpenVPN compression and proxy support to the builder layer, including
the
build_openvpn_connection()function and all supporting types.Changes
api/models/vpn.rsOpenVpnCompressionenum mapping to NMcompressandcomp-lzokeysLzomarked#[deprecated]—comp-lzois deprecated upstream in favour ofcompressNocarry VORACLE vulnerability warnings in their doc commentsOpenVpnProxyenum withHttpandSocksvariants mapping to NM proxy keysOpenVpnConfigstruct with builder methods for port, compression, proxy, DNS, and UUIDpub use vpn::*inapi/models/mod.rsand re-exported at crate root inlib.rsapi/builders/vpn.rsbuild_openvpn_connection()— builds a complete NM settings dict for OpenVPNconnection.type = "vpn",vpn.service-type = "org.freedesktop.NetworkManager.openvpn"vpn.dataasVec<(String, String)>OpenVpnCompressionvariants to correct NM keysOpenVpnProxyvariants, validates port is non-zero#[allow(deprecated)]on theLzoarm inside the builder so the function itself doesn't warnNotes
build_openvpn_connectionis wired intocore/vpn.rsdispatch but theOpenVpnarm inconnect_vpncurrently returnsVpnFailed("not yet implemented")until the fullconnect flow from openvpn support #288 lands.