Skip to content

migrate from Tequila to Microsoft Entra ID#208

Merged
PascalinDe merged 8 commits intomainfrom
203
Mar 26, 2026
Merged

migrate from Tequila to Microsoft Entra ID#208
PascalinDe merged 8 commits intomainfrom
203

Conversation

@PascalinDe
Copy link
Copy Markdown
Member

closes #203 #206 #207

@PascalinDe
Copy link
Copy Markdown
Member Author

@multiscan @dragonleman @ineiti it's currently a WIP (mostly because I want to see whether I can add some tests, also some of the variables are not exactly following the right case style), but could you still have a quick look and see if I did something obviously wrong?

I can authenticate correctly, but I'm worried about whether I'm handling all the security-critical things correctly

@PascalinDe
Copy link
Copy Markdown
Member Author

PascalinDe commented Mar 13, 2026

the failing tests are related to DELA, are also broken on the main branch and unrelated to this particular PR

@PascalinDe PascalinDe marked this pull request as draft March 13, 2026 15:44
@PascalinDe PascalinDe moved this from Active Tasks to Ready4Review in Engineer's TODO Mar 13, 2026
@PascalinDe PascalinDe marked this pull request as ready for review March 18, 2026 14:37
@PascalinDe PascalinDe changed the title WIP: migrate from Tequila to Microsoft Entra ID migrate from Tequila to Microsoft Entra ID Mar 19, 2026
Copy link
Copy Markdown
Collaborator

@multiscan multiscan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything fundamentally bad or wrong in the code.
We tested the application on the test cluster and, at least for what concerns login/logout, it seams to work.
On the other hand, I didn't manage to correctly initialize the blockchain yet. Therefore I couldn't run a full test including vote casting. I don't see why it wouldn't work.

@PascalinDe PascalinDe requested a review from multiscan March 26, 2026 13:42
Copy link
Copy Markdown
Member

@ineiti ineiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No obvious errors :)

@PascalinDe PascalinDe merged commit 955aa9b into main Mar 26, 2026
8 of 11 checks passed
@PascalinDe PascalinDe deleted the 203 branch March 26, 2026 19:20
@github-project-automation github-project-automation bot moved this from Ready4Review to Done in Engineer's TODO Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

migrate D-Voting authentication to Microsoft Entra

3 participants