migrate from Tequila to Microsoft Entra ID#208
Conversation
|
@multiscan @dragonleman @ineiti it's currently a WIP (mostly because I want to see whether I can add some tests, also some of the variables are not exactly following the right case style), but could you still have a quick look and see if I did something obviously wrong? I can authenticate correctly, but I'm worried about whether I'm handling all the security-critical things correctly |
|
the failing tests are related to DELA, are also broken on the main branch and unrelated to this particular PR |
multiscan
left a comment
There was a problem hiding this comment.
I don't see anything fundamentally bad or wrong in the code.
We tested the application on the test cluster and, at least for what concerns login/logout, it seams to work.
On the other hand, I didn't manage to correctly initialize the blockchain yet. Therefore I couldn't run a full test including vote casting. I don't see why it wouldn't work.
closes #203 #206 #207