fix: resolve build failures for missing xi library and anyhow macro#7
Open
lucasrcezimbra wants to merge 2 commits intobyteowlz:mainfrom
Open
fix: resolve build failures for missing xi library and anyhow macro#7lucasrcezimbra wants to merge 2 commits intobyteowlz:mainfrom
lucasrcezimbra wants to merge 2 commits intobyteowlz:mainfrom
Conversation
The check-deps recipe was only checking for sentencepiece on Linux, causing builds to fail when libxi-dev (xi.pc) was not installed. The x11 crate requires libxi >= 1.7, so add pkg-config checks and auto-install steps for libxi and libxtst across Debian/Ubuntu, Fedora/RHEL, and Arch Linux. Also improve the unsupported distro error message to list all required libraries.
The anyhow! macro was used on line 215 but only the anyhow crate was
in scope, not the macro. Add the macro to the existing use statement:
use anyhow::{Context, Result, anyhow};
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two build errors prevented
just install-earsfrom completing:Fix 1:
justfile— missinglibxi/libxtstdependency checksThe
check-depsrecipe only checked forsentencepieceon Linux. Thex11crate requireslibxi >= 1.7(xi.pc) at compile time, butlibxi-dev(andlibxtst-dev) were never installed by the recipe, causing the build to fail with:Fix: Added
pkg-configpresence checks and auto-install steps forlibxiandlibxtstacross Debian/Ubuntu, Fedora/RHEL, and Arch Linux. Also improved the unsupported-distro error message to list all required libraries.Fix 2:
src/virtual_keyboard.rs— missinganyhow!macro importThe
anyhow!macro was used invirtual_keyboard.rsbut only theanyhowcrate itself was imported, not the macro, causing:Fix: Added
anyhowto the existing import: