[wasmparser] Add [implements=<I>]L component name support#2453
Draft
ricochet wants to merge 1 commit intobytecodealliance:mainfrom
Draft
[wasmparser] Add [implements=<I>]L component name support#2453ricochet wants to merge 1 commit intobytecodealliance:mainfrom
[implements=<I>]L component name support#2453ricochet wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
Add parsing, validation, and uniqueness rules for the new `[implements=<interface>]label` extern name form from the component model `implements` proposal. An implements name labels an instance import/export that implements a named interface. Uniqueness: `[implements=<I>]L` conflicts with bare label `L` and with `[method]L.L` / `[static]L.L` (the existing l.l edge case), but is strongly unique from interface names, constructors, and normal method/static names. See implements feature: WebAssembly/component-model#613
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parsing, validation, and uniqueness rules for the new
[implements=<interface>]labelextern name form from the componentmodel
implementsproposal. An implements name labels an instanceimport/export that implements a named interface.
Uniqueness:
[implements=<I>]Lconflicts with bare labelLand with[method]L.L/[static]L.L(the existing l.l edge case), but isstrongly unique from interface names, constructors, and normal
method/static names.
See implements feature:
WebAssembly/component-model#613