Implement auto host function by macro#104
Open
Sieluna wants to merge 5 commits intobytecodealliance:mainfrom
Open
Implement auto host function by macro#104Sieluna wants to merge 5 commits intobytecodealliance:mainfrom
Sieluna wants to merge 5 commits intobytecodealliance:mainfrom
Conversation
Contributor
Author
lum1n0us
reviewed
Feb 3, 2025
| //! } | ||
| //! ``` | ||
| //! | ||
| #![doc = include_str!("../README.md")] |
Collaborator
|
Thank you for your contribution. It would be better to consider and include a wider variety of Rust types. A string in Rust is different from a C-style string. Given that WAMR is a C-based engine, a Rust string cannot be handled well without transformation. We might also need to consider ownership for the values of certain types. We should aim to prevent users from worrying about this aspect. wit-bindgen might provide some insights into type translation. After all, all the types we are dealing with here will first be converted into WebAssembly types, rather than directly into C types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I find this feature quite useful. If you have time, could you help check if there are any security issues?