Fix interface resolution for components exporting interface instances#173
Closed
avrabe wants to merge 1 commit intobytecodealliance:mainfrom
Closed
Fix interface resolution for components exporting interface instances#173avrabe wants to merge 1 commit intobytecodealliance:mainfrom
avrabe wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
Resolves composition failures when source components export interface instances but target components expect individual function imports. Enhanced the instance_exports() method to search inside interface instances for missing function exports when direct lookup fails. Fixes: bytecodealliance#172
Author
|
Closing this PR as the issue was determined to be in my component generation tooling, not a WAC bug. WAC is working correctly as designed. See issue #172 for full details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves composition failures when source components export interface instances but target components expect individual function imports.
Problem: WAC failed to compose components when source exports interface instances containing functions, but target expects those functions as direct exports, resulting in "instance is missing expected function export" errors.
Solution: Enhanced
instance_exports()method in subtype checker to search inside interface instances for missing exports when direct lookup fails.Testing: Verified with existing WAC test suite - all 125 resolution tests pass, including existing failure cases.
Fixes #172