Open
Conversation
emcfarlane
reviewed
Mar 5, 2026
emcfarlane
reviewed
Mar 5, 2026
intern.Table by around 65xintern.Table by around 15x
intern.Table by around 15xintern.Table cache-hit operations lock-free
emcfarlane
approved these changes
Mar 6, 2026
emcfarlane
reviewed
Mar 6, 2026
intern.Table cache-hit operations lock-freeintern.Table completely lock-free
emcfarlane
reviewed
Mar 9, 2026
emcfarlane
reviewed
Mar 9, 2026
doriable
approved these changes
Mar 10, 2026
emcfarlane
reviewed
Mar 10, 2026
emcfarlane
reviewed
Mar 10, 2026
emcfarlane
reviewed
Mar 10, 2026
doriable
approved these changes
Mar 10, 2026
emcfarlane
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes all locks in
intern.Table, replacing the map with async.Mapand the table with anatomicx.Log. This eliminates virtually all lock contention, resulting in wins on all workloads.The
sync.Mapis used to ensure that elements are only ever allocated once, usingLoadOrStoreto select the goroutine responsible for selecting the intern ID for a string. This ID is selected locklessly usingatomicx.Log. This makes every operation, except for rareatomicx.Logresizes, lockless.Here is the before and after benchmarks for a mix of hit-heavy and miss-heavy workloads (Npct means that N% of intern calls are with an uninterned value).
Notice that we see a 17x improvement for a hit-heavy workload, a 4x improvement for the 50% workload. This patch is an unambiguous performance improvement.
To validate this finky change, in addition to the compiler's tests, I've written a test that hammers an intern table directly by simulating a thundering herd.