Cleanup: auth consistency hardening and review-item consolidation

[leoafarias]

Summary

• consolidates cleanup work from the review pass into implementation-ready code changes
• hardens admin user update metadata handling (fails on metadata persistence errors) with conditional transaction path when adapters expose TypeORM repos
• removes invitation-acceptance duplication by using a single static controller path
• aligns invitation reattempt/revocation swagger status annotations with runtime behavior
• centralizes remaining deep @concepta/*/dist/* imports in a single compat shim
• preserves no-signature-change constraint for exported metadata updatable interface

Validation

• yarn build
• yarn test
• yarn test:e2e
• yarn lint

Notes

• focus is cleanup/refactor and consistency hardening; no new endpoint surface area was introduced
• consolidated local planning scratch file was removed from workspace (not part of repo history)

[docs-page]

To view this pull requests documentation preview, visit the following URL:

docs.page/btwld/rockets~23

Documentation is deployed and generated using docs.page.

[Copilot]

Pull request overview

Consolidates auth-related cleanup from a review pass, focusing on making admin user+metadata updates behave consistently on failure, reducing invitation-acceptance duplication, and stabilizing @concepta/* imports via a compat shim while keeping swagger output aligned with runtime behavior.

Changes:

• Hardened admin user update flow so user-metadata persistence failures fail the request, with a transactional path when both adapters expose compatible TypeORM repos.
• Consolidated invitation acceptance into a single static controller path and aligned invitation-related swagger status/response DTOs with runtime behavior.
• Centralized remaining deep @concepta/*/dist/* imports into a single compat re-export and cleaned up tests/docs (including removing stray it.only).

Reviewed changes

Copilot reviewed 35 out of 36 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
yarn.lock	Dependency lock updates (babel, types, minimatch, etc.).
package.json	Adds @types/minimatch dependency.
packages/rockets-server/src/rockets.module-definition.ts	Module definition tweak for controllers wiring.
packages/rockets-server/src/modules/user-metadata/services/user-metadata.model.service.ts	Preserve Nest HttpExceptions during error mapping.
packages/rockets-server/src/modules/user-metadata/services/user-metadata.model.service.spec.ts	New unit tests for exception mapping behavior.
packages/rockets-server/src/interfaces/rockets-options-extras.interface.ts	Simplifies docs/comments for extras options.
packages/rockets-server-auth/src/shared/compat/concepta-internals.ts	New compat shim centralizing deep /dist imports.
packages/rockets-server-auth/src/shared/interfaces/rockets-auth-options.interface.ts	Switches many deep imports to package roots / compat shim.
packages/rockets-server-auth/src/shared/interfaces/rockets-auth-options-extras.interface.ts	Updates docs + routes config key naming (userMetadata).
packages/rockets-server-auth/src/shared/interfaces/rockets-auth-notification.service.interface.ts	Moves AuthVerifyNotificationServiceInterface import to compat shim.
packages/rockets-server-auth/src/rockets-auth.module-definition.ts	Controller list + imports cleanup and minor nullish-coalescing adjustments.
packages/rockets-server-auth/src/guards/admin.guard.ts	Minor simplification in role lookup condition.
packages/rockets-server-auth/src/domains/user/modules/rockets-auth-admin.module.ts	Adds transaction-capable user+metadata update and strong-failure on metadata persistence.
packages/rockets-server-auth/src/domains/user/modules/rockets-auth-admin.relations.e2e-spec.ts	New e2e test ensuring admin update fails/rolls back if metadata persistence fails.
packages/rockets-server-auth/src/domains/user/modules/rockets-auth-signup.module.ts	Uses compat shim for CrudRelations import.
packages/rockets-server-auth/src/domains/oauth/controllers/auth-oauth.controller.e2e-spec.ts	Updates TypeOrmExtModule feature key to userMetadata.
packages/rockets-server-auth/src/domains/invitation/modules/rockets-auth-invitation-acceptance.module-definition.ts	Removes dynamic controller-class factory; uses static controller and refactors listener.
packages/rockets-server-auth/src/domains/invitation/controllers/invitation-acceptance.controller.ts	Simplifies accept handler; clarifies accepted payload semantics.
packages/rockets-server-auth/src/domains/invitation/controllers/invitation-revocation.controller.ts	Swagger response annotation changed to 201.
packages/rockets-server-auth/src/domains/invitation/controllers/invitation-reattempt.controller.ts	Swagger response annotation changed to 201; import via compat shim.
packages/rockets-server-auth/src/domains/invitation/dto/rockets-auth-invitation*.ts	DTO deep imports moved behind compat shim; adds response DTO usage.
packages/rockets-server-auth/src/domains/invitation/interfaces/invitation-acceptance-data.interface.ts	Simplifies docstring; clarifies default listener behavior.
packages/rockets-server-auth/src/domains/invitation/index.ts	Updates public exports (adds response DTO; trims outdated comments).
packages/rockets-server-auth/swagger/swagger.json	Updates swagger output for invitation response DTO, status codes, /me/password, and other spec adjustments.
packages/rockets-server-auth/src/generate-swagger.ts	Adds explicit contact/license metadata to swagger builder.
packages/rockets-server-auth/src/rockets-auth.module.spec.ts	Replaces deep import with compat shim for AuthRefreshStrategy.
packages/rockets-server-auth/src/rockets-server-auth-sqllite.e2e-spec.ts	Removes stray it.only.
packages/rockets-server-auth/src/domains/user/services/rockets-auth-user-metadata.model.service.spec.ts	Removes stray it.only.
packages/rockets-server-auth/src/fixtures/services/*.ts	Removes deep /dist imports for interfaces/settings.
development-guides/ROCKETS_AI_INDEX.md	Adds pointers to agent instruction files.
AGENTS.md	Adds canonical repo agent instructions + invariants.
CLAUDE.md	Symlink/alias to AGENTS.md for agent compatibility.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 35 out of 36 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.