Open
Conversation
added 6 commits
October 4, 2019 12:30
When given an IPv4 address, the string spliteAddr receives looks like: 1.2.3.4:123 Splitting on ":" is fine, because the IP address contains only integers and "." chars. When given an IPv6 address, the string spliteAddr receives looks like: [2001:0db8:85a3:0000:0000:8a2e:0370:7334]:123 The existing implementation fails on such a string. Colons are used within IPv6 addresses. My patch splits on the last ":" character, which works for both IPv4 and IPv6 addresses.
Author
|
I'm not sure how this happened, but I actually only intended one commit (93ba5e9) in the pull request. This commit adds IPv6 support. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When given an IPv4 address, the string spliteAddr
receives looks like:
1.2.3.4:123
Splitting on ":" is fine, because the IP address
contains only integers and "." chars.
When given an IPv6 address, the string spliteAddr
receives looks like:
[2001:0db8:85a3:0000:0000:8a2e:0370:7334]:123
The existing implementation fails on such a string.
Colons are used within IPv6 addresses.
My patch splits on the last ":" character, which works
for both IPv4 and IPv6 addresses.