Fixed Crash on Missing Name & State of Fixed State Machine on Run.#25
Open
RexPaster wants to merge 1 commit intobsiever:masterfrom
Open
Fixed Crash on Missing Name & State of Fixed State Machine on Run.#25RexPaster wants to merge 1 commit intobsiever:masterfrom
RexPaster wants to merge 1 commit intobsiever:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #24
Adds validation for
StateMachineelements before simulation begins to prevent the crash described in #24.If a
StateMachineis missing required information, a popup dialog is shown explaining the problem instead of allowing the simulator to start and fail later.Changes
Added validation for
StateMachineconfiguration.Displays a popup if the state machine:
Prevents the simulator from starting until the issue is fixed.
Motivation
Previously, invalid
StateMachineconfigurations could lead to aNullPointerExceptionduring simulation initialization. This change provides clear feedback to the user and avoids the crash.