Fixed Unexpected Characters Causing Crash During Animation in Signal Viewer#23
Closed
RexPaster wants to merge 2 commits intobsiever:masterfrom
Closed
Fixed Unexpected Characters Causing Crash During Animation in Signal Viewer#23RexPaster wants to merge 2 commits intobsiever:masterfrom
RexPaster wants to merge 2 commits intobsiever:masterfrom
Conversation
RexPaster
commented
Mar 8, 2026
|
|
||
| import jls.*; | ||
| import jls.elem.*; | ||
| import jls.sim.InterractiveSimulator.Traces; |
Author
There was a problem hiding this comment.
Remove accidental auto-import of Traces
VS Code automatically added the import:
import jls.sim.InterractiveSimulator.Traces;I missed this addition in my original commit.
Author
|
Closing as a fix is already proposed in #8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied a numerical filter to the "step" field in the simulator to prevent crashes when non-numerical characters are entered. The crash occurs when triggering the Animate button.