Draft
Conversation
3fc2b19 to
62e3fb4
Compare
04da066 to
21a66ec
Compare
62e3fb4 to
14b83a6
Compare
21a66ec to
6708c39
Compare
14b83a6 to
00de1c3
Compare
6708c39 to
4da02e3
Compare
00de1c3 to
abc7026
Compare
4da02e3 to
e76c0e1
Compare
abc7026 to
7258bee
Compare
e76c0e1 to
4047e6c
Compare
7258bee to
40eb370
Compare
4047e6c to
a71a6b7
Compare
40eb370 to
1b28cde
Compare
a71a6b7 to
3c4f160
Compare
1b28cde to
f50802c
Compare
3c4f160 to
1f4bffd
Compare
f50802c to
ac1c6dc
Compare
1f4bffd to
78a2b91
Compare
ac1c6dc to
e9a3cc1
Compare
78a2b91 to
f35061b
Compare
e9a3cc1 to
9af8e28
Compare
f35061b to
04c6545
Compare
9af8e28 to
cf00273
Compare
04c6545 to
0ee302e
Compare
cf00273 to
6d78ec5
Compare
0ee302e to
617749c
Compare
6d78ec5 to
706cd36
Compare
617749c to
a7c5dfa
Compare
706cd36 to
c4dd9c4
Compare
a7c5dfa to
bf0ece0
Compare
c4dd9c4 to
a35feda
Compare
bf0ece0 to
1321324
Compare
a35feda to
2b5ad28
Compare
- num_epochs was passed where num_workers was expected in make_data_loader call, potentially launching hundreds of workers - calculate_pruning_thresholds had a vestigial for-loop that always returned on the first iteration; removed the loop - Added division-by-zero guards with informative error messages in error rate and inverse error rate calculations - Fixed operator precedence bug: a + b % c evaluated as a + (b % c) instead of (a + b) % c for fold index - Fixed return type annotation: List[int] -> Generator[Datum, None, None] - Fixed wrong argparse descriptions in prune_dataset.py and edit_dataset.py (both said "train the Mutect3 artifact model")
2b5ad28 to
0137d52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
num_epochspassed wherenum_workersexpected inmake_data_loader, potentially launching hundreds of worker processescalculate_pruning_thresholdshad a vestigialfor fold in range(NUM_FOLDS)loop that always returned on the first iteration; removed the loopValueErrormessages in error rate calculationsa + b % cevaluated asa + (b % c)instead of(a + b) % cfor fold indexList[int]->Generator[Datum, None, None]prune_dataset.pyandedit_dataset.py(both incorrectly said "train the Mutect3 artifact model")Test plan
test_prune_datasetintegration test passes