Consistently use browser.i18n language#489
Open
Cimbali wants to merge 1 commit intobrief-rss:masterfrom
Open
Conversation
Author
|
Updated to avoid conflict with 2a0b9e1 |
Member
|
Thank you for updating. Sorry, I'm dealing with some deadlines now, so won't be able to work on Brief for the next couple weeks. |
Author
|
No worries ! I’m running the alpha now and it’s going smoothly. 👍 |
Make the language used for date formatting and document lang attribute consistent with the language used for strings by using browser.i18n for both mechanisms (instead of something relying on navigator.language which is a different setting). Also fixes the problems when navigator.language is not specified, see brief-rss#487 and brief-rss#274.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the same language for date formatting and document
langattribute than the one used for the rest of i18n bybrowser.i18n.getMessage(), by gettingbrowser.i18n.getUILanguage()instead of navigator.language (which is a different setting).Also fixes the problems when navigator.language is not specified, see #487 and #274.