Conversation
tanriol
left a comment
tanriol
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
This looks nice overall, but there are a few style-related problems and the big problem with non-obvious UI marker.
| @@ -553,6 +553,10 @@ export let Database = { | |||
| modified = parseDateValue(parsedFeed.updated); | |||
| } | |||
| if(!entries.length || (modified && modified <= feed.dateModified)) { | |||
There was a problem hiding this comment.
This block will likely be modified / removed in the near future as quite some feeds have incorrect dateModified, but for now looks correct.
| language: parsedFeed.language, | ||
| lastUpdated: Date.now(), | ||
| dateModified: modified, | ||
| error: false, |
There was a problem hiding this comment.
May be a good idea to also store a timestamp of the last successful fetch as "this feed failed to update last time" and "this feed could not update for two months" are different situations.
| .unread-count, | ||
| .error-status { | ||
| min-width: 2em !important; | ||
| margin-left: auto !important; |
There was a problem hiding this comment.
Having this attribute for both items causes them to be spaced in a weird way if both are displayed.
There was a problem hiding this comment.
I tried to apply different styles, but none was good enough. So I removed the circle and painted feed titles in red instead.
There was a problem hiding this comment.
We can also replace feed icon with https://github.com/brief-rss/brief/blob/master/icons/error.png. feedlist.css contains some css rules for that, probably left from the pre-webext days.
| tree-folder:not(.unread) > tree-folder-header > .unread-count, | ||
| tree-folder:not(.collapsed) > tree-folder-header > .unread-count, | ||
| tree-item:not(.unread) > .unread-count { | ||
| visibility: hidden; |
There was a problem hiding this comment.
The unread count was intentionally visibility: hidden; instead of display: none; to make the text cutoff points better aligned. Compare the following screenshots:
- display: none;
- visibility: hidden;
ui/brief.xhtml
Outdated
| <img class="icon"/> | ||
| <label class="title"/> | ||
| <label class="unread-count"/> | ||
| <label class="error-status">●</label> |
There was a problem hiding this comment.
The main problem is that a brown circle (okay, even a red circle) is not exactly obvious and it lacks any kind of description. How is the user supposed to know it means "this feed failed to load last time"? This definitely needs a textual comment of some kind.
2 participants
Fixes #418