Fix ICU detection to use actual installed version on macOS#198
Merged
tenderlove merged 1 commit intobrianmario:masterfrom Jan 12, 2026
Merged
Fix ICU detection to use actual installed version on macOS#198tenderlove merged 1 commit intobrianmario:masterfrom
tenderlove merged 1 commit intobrianmario:masterfrom
Conversation
The previous implementation used `brew --prefix icu4c` which returns the path where the latest icu4c package would be installed, not necessarily where an installed version actually exists. If a user has an older versioned package installed (e.g., icu4c@77), the path `/opt/homebrew/opt/icu4c` would not exist, causing the build to fail. This change: - Detects all installed icu4c packages (including versioned ones) - Selects the latest installed version - Uses that version's actual installation path This ensures the build works correctly when users have versioned ICU packages installed via Homebrew.
stanhu
force-pushed
the
sh-improve-homebrew-checking
branch
from
2ea9206 to
b8a81e0
Compare
Contributor
Author
|
@tenderlove Could I trouble you for a review and release for this? It seems that many of my team members are getting bit by this problem now that Homebrew released icu4c 78. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation used
brew --prefix icu4cwhich returns the path where the latest icu4c package would be installed, not necessarily where an installed version actually exists.If a user has an older versioned package installed (e.g., icu4c@77), the path
/opt/homebrew/opt/icu4cwould not exist, causing the build to fail.This change:
This ensures the build works correctly when users have versioned ICU packages installed via Homebrew.