Open
Conversation
Add some codec twiddling to explicitly convert string-oriented json output to byte-oriented stream input. I believe this remains backwards-compatible with python 2.7.
Add an optional `--url` flag; when present, the supplied URL is used in place of the S3 bucket-based URL. It should be in the form "https://myhost.mydomain" (without a trailing slash).
Add an optional `--url` flag; when present, the supplied URL is used in place of the S3 bucket-based URL. It should be in the form "https://myhost.mydomain" (without a trailing slash).
Owner
|
Partially my fault as well for doing a force-push after you forked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2.
This allows the user to use an explicitly-provided URL instead of one generated from the bucket name; it's useful particularly for CloudFront, where we want to expose a FQDN that is totally different from the underlying bucket name.
NB. I am not a git wizard, and there's still some old IO. crud that leaked through despite my best efforts to clean up this PR. Just ignore the obviously non-url-related crud in the diff.
Thanks,
Scott