fix(ci): combined CI workarounds (#697 + #698)

[diberry]

Summary

Consolidates PRs #697 and #698, which both modify .github/workflows/squad-ci.yml to fix the same root cause: @github/copilot-sdk's ESM import of vscode-jsonrpc/node (missing .js extension) breaking CI on Linux runners.

What each PR did

PR	Approach	Effect
#697	Skip workaround — added SKIP_SAMPLES (streaming-chat) and SKIP_EXPORTS (./client) lists to bypass the failing tests	Tests skipped entirely
#698	Proper fix — run the existing patch-esm-imports.mjs script after npm ci --ignore-scripts	Root cause patched, all tests run

Resolution

#698's approach wins. The repo already has packages/squad-cli/scripts/patch-esm-imports.mjs (added for issue #449) that patches the missing ESM extension. It runs as a postinstall hook, but CI uses npm ci --ignore-scripts which skips lifecycle hooks. Adding an explicit node packages/squad-cli/scripts/patch-esm-imports.mjs step after npm ci in both affected jobs fixes the actual problem — making #697's skip-based workaround unnecessary.

What changed

.github/workflows/squad-ci.yml — 2 lines added:

1. samples-build job (line ~354): node packages/squad-cli/scripts/patch-esm-imports.mjs after npm ci --ignore-scripts
2. export-smoke-test job (line ~725): Same patch step after npm ci --ignore-scripts

Root cause

@github/copilot-sdk@0.1.32's dist/session.js imports vscode-jsonrpc/node without a .js extension. Since vscode-jsonrpc@8.2.1 has no exports field, Node.js 22+ strict ESM resolution fails. The existing patch script injects the missing exports field into vscode-jsonrpc/package.json.

Re-enable conditions

Remove the patch steps when @github/copilot-sdk ships ESM-compliant imports (i.e., vscode-jsonrpc/node.js instead of vscode-jsonrpc/node). Upstream: github/copilot-sdk#707

Why consolidate

Both PRs touch the same file with overlapping intent. Shipping them separately would create a confusing git history and the skip workaround from #697 would immediately become dead code once #698's fix lands.

Refs: #697, #698

[Copilot]

Pull request overview

Consolidates prior CI mitigations into the workflow by explicitly running the existing ESM patch script after npm ci --ignore-scripts, addressing Node 22+ ESM resolution failures caused by @github/copilot-sdk importing vscode-jsonrpc/node without a .js extension.

Changes:

• Run packages/squad-cli/scripts/patch-esm-imports.mjs in samples-build after dependency install.
• Run the same patch step in export-smoke-test after dependency install.

[diberry]

✅ CI Review: APPROVED

Verdict: Correct consolidation. The ESM patch is properly placed and applied uniformly.

Workflow Correctness

✅ ESM patch placement is correct. The patch runs immediately after
pm ci --ignore-scripts\ and before downstream tasks (
pm run build), allowing it to fix the vscode-jsonrpc import issue before TypeScript compilation attempts to resolve it.

Job Coverage

✅ Both affected jobs patched consistently:

• \samples-build\ job: patch added at line 354
• \�xport-smoke-test\ job: patch added at line 724

No gaps. Both jobs have identical CI sequence:
pm ci --ignore-scripts\ →
ode packages/squad-cli/scripts/patch-esm-imports.mjs\ → build/test.

Idempotency

✅ Patch is idempotent. The \patch-esm-imports.mjs\ script (packages/squad-cli/scripts/patch-esm-imports.mjs) modifies vscode-jsonrpc's package.json to inject missing \�xports\ field. Running multiple times writes the same value—safe.

File Scope

✅ Only squad-ci.yml modified. Diff shows 2 lines added (both patch steps), 0 .squad files touched. Clean scope.

Note: This consolidation eliminates the skip-based workaround (#697 approach), allowing all tests to run. The upstream issue (#707 in copilot-sdk) will determine when to remove the patch step. 🛡️

[diberry]

FIDO's Quality Review ✓

Verdict: APPROVED — Sound consolidation with correct root-cause fix.

Correctness ✅

The ESM patch approach is solid. PR #698's strategy (run existing \patch-esm-imports.mjs\ after
pm ci --ignore-scripts) correctly addresses the root cause:

• @github/copilot-sdk@0.1.32\ imports \�scode-jsonrpc/node\ without .js\ extension
• \�scode-jsonrpc@8.2.1\ lacks an \�xports\ field, breaking Node 22+ strict ESM resolution
• The patch script injects proper exports + defense-in-depth rewrite of the import
• Existing script already used in postinstall; CI bypass requires explicit invocation ✓

Scope ✅

Minimal and correct. Only .github/workflows/squad-ci.yml\ modified:

• 2 identical patch lines in \samples-build\ (line 354) and \�xport-smoke-test\ (line 725)
• No .squad files touched
• Consolidates PRs fix(ci): workaround @github/copilot-sdk ESM bug (vscode-jsonrpc/node) #697 & fix(deps): resolve vscode-jsonrpc/node module resolution for @github/copilot-sdk #698 by adopting fix(deps): resolve vscode-jsonrpc/node module resolution for @github/copilot-sdk #698's fix over fix(ci): workaround @github/copilot-sdk ESM bug (vscode-jsonrpc/node) #697's skip-workaround

Regression Risk ✅ (Low)

• Patch script already battle-tested for issue squad-cli fails with ERR_MODULE_NOT_FOUND on Node 22 (vscode-jsonrpc ESM import) #449
• Script is idempotent (checks for existing exports, safe to re-run)
• Defense-in-depth approach (Layer 1: exports, Layer 2: session.js rewrite) handles multiple failure modes
• All tests re-enabled (vs. fix(ci): workaround @github/copilot-sdk ESM bug (vscode-jsonrpc/node) #697's skip-based approach)

Supersession ✓

Both PRs properly closed:

• fix(ci): workaround @github/copilot-sdk ESM bug (vscode-jsonrpc/node) #697 (CLOSED) — skip workaround made obsolete by fix(deps): resolve vscode-jsonrpc/node module resolution for @github/copilot-sdk #698's proper fix
• fix(deps): resolve vscode-jsonrpc/node module resolution for @github/copilot-sdk #698 (CLOSED) — its fix is adopted wholesale here
• Git history clean: single consolidation PR vs. two partial solutions

Edge Cases Considered ✓

• Works with npm workspaces, local installs, global installs (multiple search roots in patch script)
• Idempotent re-runs (checks for existing exports before patching)
• Upstream dependency (copilot-sdk feat: organize agent work output into task-scoped folders (.squad/work/{issue}-{slug}/) #707) tracked for eventual removal

Sign-off: Ready to merge. No test coverage concerns — existing tests now run unblocked.