fix(ci): strip trailing slash from sample_dir path variable#693
Merged
diberry merged 1 commit intobradygaster:devfrom Mar 29, 2026
Merged
fix(ci): strip trailing slash from sample_dir path variable#693diberry merged 1 commit intobradygaster:devfrom
diberry merged 1 commit intobradygaster:devfrom
Conversation
Fixes double-slash in path construction (./samples/name//package.json) found by Copilot code review. The glob samples/*/ produces paths with trailing slash which caused redundant // in require() paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
🤖 Copilot Code Review Finding Issue: Shell variable expansion inside double-quoted Node.js string |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the samples-build CI job by normalizing sample_dir values produced by the samples/*/ glob so downstream path interpolation doesn’t produce double slashes.
Changes:
- Strip the trailing
/fromsample_dirinside the samples loop to prevent paths like./samples/name//package.json.
robzelt
pushed a commit
to robzelt/squad
that referenced
this pull request
Apr 1, 2026
…trol-docs docs: add remote control (squad start --tunnel) documentation
robzelt
pushed a commit
to robzelt/squad
that referenced
this pull request
Apr 1, 2026
Session: 2026-03-03T20-42-41Z-pr693-merge Requested by: Brady Changes: - Logged Kobayashi orchestration (PR bradygaster#693 merge to main, version conflict resolution) - Logged PR bradygaster#693 merge session - Merged decision inbox (hockney-docker-fix) into decisions.md - Deleted inbox file Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Strips trailing slash from sample_dir in samples-build CI job.
Why
Copilot code review found that the glob pattern samples/*/ produces paths with trailing slash. When interpolated into require('.//package.json'), this creates ./samples/name//package.json (double slash). While Unix tolerates this, it's incorrect and could fail on some systems.
How
Adds \ to strip trailing slash after the for loop iterator.
Copilot Review Finding
This was identified by automated Copilot code review on the merged upstream dev branch after PRs #690, #691, #692 were squash-merged.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com