Conversation
|
add : bump stylist to 0.14 and Fix the CI |
|
Thank you for the PR. I think there are some issues with the documenting feature which causes an upstream dependency not being able to be built. I think this should be address first. |
|
@futursolo you are absolutely right, and i see that have you already created the fix on futursolo/stylist-rs#172 i will update this PR when the doc is fixed. |
|
They still haven’t fixed it. I will try to merge the PR now if the tests pass. |
|
@Aedius can you update to yew 0.23 while you are at it? |
| #[function_component(App)] | ||
| #[component(App)] | ||
| fn app() -> Html { |
There was a problem hiding this comment.
The PascalCase function-name-as-component-name style has more aura and is what yewstack/yew adopts in its docs and examples currently:
#[component]
fn App() -> Html{
// ...
}There was a problem hiding this comment.
As far as I know, both naming styles are valid scheme.
One is named function and the other one is unnamed.
Description
This pull request consists of the following changes:
This PR bump Yew from 0.21 to 0.22 and stylish from 0.13 to 0.14
NB : i also have bump Yew on stylist-rsso we need to replace the link to my fork ( https://github.com/Aedius/stylist-rs.git ) on the dependenciesChecklist
CHANGELOG.md.