feat(search): --json JSON Lines output (ripgrep-compatible)#6
Merged
feat(search): --json JSON Lines output (ripgrep-compatible)#6
Conversation
Add SearchOutputFormat Text|Json and wire grep_printer::JSON for standard/ only-matching search. Emit begin/match/context/end per file plus final summary; quiet JSON discards match lines but keeps summary. CLI: --json/ --no-json, conflicts with count/file-list modes, implicit stderr stats. Integration tests and rg compat matrix updated.
botirk38
force-pushed
the
feat/json-output
branch
from
de742a1 to
e8f1940
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
--json/--no-json(last flag wins) andSearchOutputFormat::Jsoninsift-core. Search usesgrep_printer::JSONwithsink_with_pathso stdout matches ripgrep's JSON Lines format:begin,match,context,endper file, plus a finalsummaryobject withelapsed_totaland aggregated stats.Behavior (aligned with rg)
--count,--count-matches,--files-with-matches,--files-without-match(clear error).--jsonimplies line numbers for the search and stderr stats (like rg's implicit--stats).summaryline still emitted.API
SearchOutput.format: SearchOutputFormat(Text|Json).JsonOutputIncompatibleMode,JsonSerialize.Tests / docs
crates/cli/tests/integration_json.rsdocs/rg-compat-matrix.md(--jsonrow)Validation
cargo fmt --check,cargo clippy -D warnings,cargo test --workspace --all-features