feat: context lines (-A/-B/-C) for standard search#1
Merged
Conversation
Owner
botirk38
commented
Apr 3, 2026
botirk38
commented
- SearchOptions: before_context, after_context; SearcherBuilder wiring and cache key
- StandardSink: context + context_break; match vs context line-number separator (: vs -)
- Summary/count paths disable context in searcher; only-matching clears context opts
- CLI: resolve_context_from_args (argv order) + ContextDecl for clap acceptance
- Tests: integration_context; update SearchOptions struct literals across bench/fuzz/profile
- SearchOptions: before_context, after_context; SearcherBuilder wiring and cache key - StandardSink: context + context_break; match vs context line-number separator (: vs -) - Summary/count paths disable context in searcher; only-matching clears context opts - CLI: resolve_context_from_args (argv order) + ContextDecl for clap acceptance - Tests: integration_context; update SearchOptions struct literals across bench/fuzz/profile
- Split resident_set_bytes into cfg-specific functions to fix missing_const_for_fn on Windows - Fix context-line prefix to use hyphen separator (path-1-context vs path:2:match) - Add integration tests for -A, -B, filename separator, and match group separation CI-equivalent: cargo clippy --workspace --all-targets --all-features passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.