This repository was archived by the owner on Mar 8, 2024. It is now read-only.
Add request cache policy#24
Open
yapryntsev wants to merge 2 commits intoborchero:masterfrom
yapryntsev:feature/request-cache-policy
Open
Add request cache policy#24yapryntsev wants to merge 2 commits intoborchero:masterfrom yapryntsev:feature/request-cache-policy
yapryntsev wants to merge 2 commits intoborchero:masterfrom
yapryntsev:feature/request-cache-policy
Conversation
added 2 commits
March 1, 2021 19:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idea
Sometimes it is wise not to cache some requests that belong to the same HttpService. It's not possible right now, and as a result, you must create multiply HttpServices with cache hook and without. The idea is that let request decide if the response should be cached.
Solution
Add a new property for the
Requestprotocol, which is then used by the cache hook to determine if the response should be cached. For example:This property will be used in default
CachingServiceHook, but you are also free to use this property in your cache-layer implementation