Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the rustix dependency to version 1.1 and replaces heap-allocated Vec buffers with stack-allocated [MaybeUninit; N] arrays for ancillary data processing in both the Sender and Receiver. However, the review feedback correctly identifies that these byte arrays do not guarantee the alignment required for cmsghdr structures, which may result in alignment faults or EINVAL errors from the kernel. Furthermore, the fixed-size buffer in the Sender may cause failures if the number of file descriptors exceeds the hardcoded limit, despite the system being configurable for larger batches.
Using an old version was accidental, definitely don't want two versions of rustix in the dependency graph. Signed-off-by: Colin Walters <walters@verbum.org>
henrywang
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using an old version was accidental, definitely don't want two versions of rustix in the dependency graph.