sd-boot: Don't generate random seed for generic images#2134
Open
Johan-Liebert1 wants to merge 1 commit intobootc-dev:mainfrom
Open
sd-boot: Don't generate random seed for generic images#2134Johan-Liebert1 wants to merge 1 commit intobootc-dev:mainfrom
Johan-Liebert1 wants to merge 1 commit intobootc-dev:mainfrom
Conversation
For installations with `--generic-image` we don't really want a random-seed file to be generated in the ESP as these images would most likely be reused Closes: bootc-dev#2133 Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the install_systemd_boot function in crates/lib/src/bootloader.rs. It updates the function signature to utilize the configopts parameter, which was previously ignored. The configopts are now used to conditionally add the --random-seed no argument to the bootctl install command if configopts.generic_image is true. This change allows for more flexible systemd-boot installation behavior based on the image type. There are no review comments to address.
cgwalters
approved these changes
Apr 9, 2026
Collaborator
Author
|
Restarted some failed checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For installations with
--generic-imagewe don't really want a random-seed file to be generated in the ESP as these images would most likely be reusedCloses: #2133