ostree-ext: reuse prior packing with exclusive components#2109
ostree-ext: reuse prior packing with exclusive components#2109officialasishkumar wants to merge 1 commit intobootc-dev:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
The pull request modifies the basic_packing_with_prior_build function in crates/ostree-ext/src/chunking.rs to correctly handle exclusive-component bins. It introduces logic to filter out empty bins from the prior build while ensuring the final reserved bin for new packages is preserved. Additionally, the bin size validation check has been moved to execute after this filtering process. A new test case, test_advanced_packing_with_prior_exclusive_components, was added to verify that the prior layout remains reusable after exclusive bins are removed. I have no feedback to provide.
|
This seems pretty good, the failures seem like flakes. Thanks @officialasishkumar you had something else you wanted to add? |
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
977071e to
a62ca1b
Compare
|
@jmarrero Nothing else to add from my side right now. I refreshed the branch onto current main, and I will keep an eye on the flakes and the updated checks. |
Summary
Reuse the prior-build packing layout when exclusive components have already been split into dedicated layers.
Changes
Testing
cargo fmt --check --alldocker run --rm -v /home/ashish/asish_workspace/personal/bootc:/src -w /src fedora:42 bash -lc 'set -euo pipefail && dnf -y install rust cargo pkgconf-pkg-config glib2-devel ostree-devel openssl-devel systemd-devel libzstd-devel git gcc make && cargo test -p ostree-ext test_advanced_packing -- --nocapture && cargo test -p ostree-ext test_exclusive_chunks -- --nocapture'Fixes #2057