mark_sweep: add Gc::new_cyclic_in parity semantics and tests#71
Open
Flamki wants to merge 1 commit intoboa-dev:mainfrom
Open
mark_sweep: add Gc::new_cyclic_in parity semantics and tests#71Flamki wants to merge 1 commit intoboa-dev:mainfrom
Flamki wants to merge 1 commit intoboa-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #63
This PR adds
Gc::new_cyclic_inparity support for both mark-sweep collectors, following Boa semantics whereweak.upgrade()returnsNoneinside the construction closure until the object is fully initialized.What changed
Gc::new_cyclic_inin:mark_sweep::pointers::Gcmark_sweep_arena2::pointers::Gcalloc_empty_ephemeron_nodein mark-sweep collector APIsWeakGcBox::new_emptyEphemeron::<K, ()>::new_emptyEphemeron::<K, ()>::set_keyWeakGc::from_raw+WeakGc::set_key(crate-visible)new_cyclic_closure_cannot_upgrade_before_initWhy
Gc::new_cyclicis still listed as a parity gap in #63.This closes that gap while keeping scope limited to mark-sweep internals and tests.
Scope
Validation
cargo fmt --all -- --checkcargo test --workspace -qcargo clippy --workspace --all-features --all-targets -q