Refactor/lexer hex optimization ,#5108#5109
Refactor/lexer hex optimization ,#5108#5109MayankRaj435 wants to merge 1 commit intoboa-dev:mainfrom
Conversation
|
@jedel1043 @nekevss Please review it once at your convenience ,thanks |
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5109 +/- ##
===========================================
+ Coverage 47.24% 59.58% +12.33%
===========================================
Files 476 589 +113
Lines 46892 63449 +16557
===========================================
+ Hits 22154 37804 +15650
- Misses 24738 25645 +907 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Unrelated change from another PR
There was a problem hiding this comment.
fixed those ,please review it .Thanks
Test262 conformance changes
Tested main commit: |
Optimize hex escape parsing in lexer
This Pull Request fixes/closes #5108.
It changes the following:
u32accumulator.Vec<u32>and String) that were previously used as buffers foru32::from_str_radixandu16::from_str_radix.take_untilmethod from core/parser/src/lexer/cursor.rs as it is no longer used by the optimized escape sequence parsing.Verification Results:
boa_parsertest suite.cargo fmtandcargo clippy -- -D warningswithout any issues.