You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Implements steps 1 & 2 of the spec: validates this is a Temporal.Instant object
Accepts locales and options arguments (previously ignored with _)
Falls back to to_ixdtf_string_with_provider until Intl.DateTimeFormat integration is complete
Removes the vague TODO: Update for ECMA-402 compliance comment.
Full Intl.DateTimeFormat integration (steps 3 & 4) is blocked on #5080, which adds format_date_time_locale and FormatDefaults::All. Once that merges, this can be updated to use that function directly.
❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.65%. Comparing base (6ddc2b4) to head (84da348). ⚠️ Report is 921 commits behind head on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlockedWaiting for another code changeC-BuiltinsPRs and Issues related to builtins/intrinsicsC-TestsIssues and PRs related to the tests.Waiting On ReviewWaiting on reviews from the maintainers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #5087.
It changes the following:
thisis aTemporal.Instantobjectlocalesandoptionsarguments (previously ignored with_)to_ixdtf_string_with_provideruntilIntl.DateTimeFormatintegration is completeTODO: Update for ECMA-402 compliancecomment.Full
Intl.DateTimeFormatintegration (steps 3 & 4) is blocked on #5080, which addsformat_date_time_localeandFormatDefaults::All. Once that merges, this can be updated to use that function directly.Spec: https://tc39.es/proposal-temporal/#sec-temporal.instant.tolocalestring