Closed
Conversation
Issue #2: Grouped jackknife Imat construction was using sapply(seq_len_m, sample.int, ...) which passed iteration values as the first positional arg of sample.int, overriding the keyword n= and enabling replacement. Fix: matrix(sample.int(n, n-r), nrow=m) restores the correct without-replacement partition. Regenerated bcajack fixture since old fixture captured buggy acceleration values. Issue #7: Matrix subsetting x[-i, ] on single-column matrices drops the dimension, returning a vector instead of a matrix. This causes type inconsistency between jackknife (vector) and bootstrap (matrix) calls to func. Fix: drop=FALSE on all 5 matrix subsetting sites that pass data to func (jackknife_accel, bootstrap_resample, bca_nonpar). Issue #4/#1 (+ PR #5 idea): regression_accel silently produced NAs when ncol(Y) > length(nearby_idx), making lm() underdetermined. Fix: explicit check with actionable error message suggesting to increase B, increase kl_fraction, or use accel="jackknife". PR #8 (Bettina Gruen): Missing return() in K=0 path was already fixed in the tidy rewrite — bca_nonpar/bca_par use explicit return(new_bcaboot(...)).
Replace stop/warning/cat with cli::cli_abort/cli_warn/cli_text/cli_h3 across all R files for consistent, formatted output: - Error messages with bullet points and styled arg/code/pkg references - Print method with cli headers and styled labels - Warnings with cli formatting - Add cli to Imports in DESCRIPTION
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed up issues