Fixes unicode support on gtfs#15
Open
fserb wants to merge 2 commits intobmander:masterfrom
fserb:master
Open
Conversation
|
Any chance this is fixed at some point? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I was trying to use GTFS to parse some utf-8 data, and it was failing with weird UnicodeEncodeError.
I traced this down to two factors:
My first commit changes the test data to have one entry on Stops that has utf-8 characters, hence breaking the tests.
My second commit fixes both issues and makes the tests pass again:
to fix 1, I've made a special case for str on umapped_entities to convert to unicode() instead of str().
to fix 2, I've created a unicode_csv_reader function that wraps around csv.reader/codes.iterdecode. The steps here are a bit annoying: iterdecode() from utf-8, encode it back, so csv.reader is fine with it, get the output from csv.reader and decode it back to utf-8, so we have the final utf-8 output.
thanks for attention,
[]s
F.