Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an incorrect validation error message in the smart-round library. The error message previously stated that "minDecimals should be larger than maxDecimals" when the validation actually checks if minDecimals is greater than maxDecimals, which should be an invalid condition.
- Updates the error message to correctly state "minDecimals should not be larger than maxDecimals"
- Updates the corresponding test description and expected error message to match the corrected validation
- Bumps the package version from 3.0.0 to 3.0.1
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/index.ts | Corrects the validation error message for the minDecimals/maxDecimals comparison |
| test/src.index.spec.ts | Updates test description and expected error message to match the corrected validation |
| package.json | Bumps version to 3.0.1 for the bug fix release |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mbonfoster
approved these changes
Sep 15, 2025
gabmontes
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While developing on Hemi, I came across this incorrect error message:
minDecimalsshould be smaller thanmaxDecimals, but the error message states otherwise. This PR fixes the error message + the test