Skip to content

Bump smart-round to newest deps and TS#3

Merged
gndelia merged 1 commit intomasterfrom
love-to-smart-round
Feb 21, 2025
Merged

Bump smart-round to newest deps and TS#3
gndelia merged 1 commit intomasterfrom
love-to-smart-round

Conversation

@gndelia
Copy link
Contributor

@gndelia gndelia commented Feb 21, 2025

This PR

  • bumps smart-round to be implemented in Typescript
  • bumps all dependencies, adds better test coverage (and uses vitest which has native support for typescript tests)
  • Removes the deprecated dependency accounting, and replaces its usage with using the native Intl.NumberFormat
  • Add better CI and tooling process (Github Actions instead of Travis, adding knip, prettier, etc)
  • Exports an ESM build, although it still provides a CommonJs build.

Closes #2
Related to hemilabs/ui-monorepo#860

Version is bumped to 2.0.0 due to the ESM support and because I switched the exported function to be a named export (import { smartRound } from 'smart-round' instead of import smartRound from 'smart-round')

@gndelia gndelia requested a review from gabmontes February 21, 2025 03:04
@gndelia gndelia self-assigned this Feb 21, 2025
@gndelia gndelia merged commit 3002b91 into master Feb 21, 2025
8 checks passed
@gndelia gndelia deleted the love-to-smart-round branch February 21, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate accounting dependency

3 participants