Conversation
gabmontes
requested review from
Copilot,
gndelia,
leanazulyoro,
maxivarela and
mbonfoster
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the promise-swr library where multiple concurrent calls could trigger multiple revalidations during the stale-while-revalidate process. The fix adds a check to prevent revalidation when one is already in progress.
- Adds a condition to prevent concurrent revalidations by checking
!cached.revalidating - Removes the debug dependency and all debug logging statements
- Improves TypeScript documentation with generic type parameters
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/promise-swr/src/index.js | Fixes concurrent revalidation bug, removes debug logging, and adds TypeScript-style documentation |
| packages/promise-swr/package.json | Removes debug dependency and bumps version to 1.0.2 |
| packages/promise-swr/README.md | Adds documentation clarifications for maxAge and resolver options |
gabmontes
force-pushed
the
fix-p-swr-revalidation
branch
from
fee1385 to
3ccc412
Compare
gabmontes
force-pushed
the
fix-p-swr-revalidation
branch
from
3ccc412 to
ca7dd1e
Compare
gndelia
approved these changes
Aug 8, 2025
mbonfoster
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor bug when revalidating in
promise-swr: If multiple calls to the wrapper were executed, multiple calls to the wrapped functionfncould be made during the time it would take to revalidate (34be133).Several other documentation and minor improvements were added.
PS: Thanks Copilot for helping me find this improvement opportunity!
Process checklist
Metrics
Actual effort: 1.5h