refactor: make Prometheus functionality optional#2
Merged
blind-oracle merged 1 commit intoblind-oracle:mainfrom Mar 8, 2025
Merged
refactor: make Prometheus functionality optional#2blind-oracle merged 1 commit intoblind-oracle:mainfrom
blind-oracle merged 1 commit intoblind-oracle:mainfrom
Conversation
Owner
|
Thanks, makes sense! |
Contributor
Author
|
Thank you for merging! |
Owner
|
I will release a new version asap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have found that the
prometheuscrate depends on versions of thepathbufcrate that are vulnerable to RUSTSEC-2024-0437. To mitigate this risk and reduce software bloat, I propose making theocsp-staplercrate optionally depend on theprometheuscrate.I have added a feature flag for
prometheus, which is enabled by default to ensure that existing users continue to have access to its functionality without disruption. Users who do not requireprometheuscan disable this feature in their configuration.This change has been tested to ensure that it does not break existing functionality, and I updated the documentation to reflect this new feature flag.