BIP32: edits by ddustin for clarity#1903
Merged
murchandamus merged 1 commit intobitcoin:masterfrom Mar 5, 2026
Merged
Conversation
jonatack
added
Proposed BIP modification
Pending acceptance
jonatack
changed the title
Member
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
Compared to #785 and found to match the old pull request in combination with the outstanding review comments from the BIPs authors except for the mentioned spot.
jonatack
force-pushed
the
2025-07-PR785-ddustin-edits-to-BIP32
branch
from
3fa6bc7 to
879066d
Compare
Member
|
@sipa: Could you take another look at these few lines? |
sipa
reviewed
Mar 5, 2026
murchandamus
added
the
PR Author action required
jonatack
force-pushed
the
2025-07-PR785-ddustin-edits-to-BIP32
branch
from
879066d to
1092536
Compare
jonatack
removed
the
PR Author action required
Co-authored-by: Pieter Wuille <pieter@wuille.net> Co-authored-by: Murch <murch@murch.one> Co-authored-by: Jon Atack <jon@atack.com>
jonatack
force-pushed
the
2025-07-PR785-ddustin-edits-to-BIP32
branch
from
1092536 to
dfdbbd1
Compare
sipa
reviewed
Mar 5, 2026
murchandamus
removed
the
Pending acceptance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up @ddustin's work in #785, updated with the latest reviewers' feedback.