Skip to content

chore: upgrade Astro v6#4073

Open
ematipico wants to merge 4 commits intomainfrom
chore/upgrade-astro-v6
Open

chore: upgrade Astro v6#4073
ematipico wants to merge 4 commits intomainfrom
chore/upgrade-astro-v6

Conversation

@ematipico
Copy link
Member

Summary

Closes #4070

Feel free to take over or add other commits in order to fix the build if it fails

@netlify
Copy link

netlify bot commented Mar 16, 2026

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 3a77d5b
🔍 Latest deploy log https://app.netlify.com/projects/biomejs/deploys/69c10108706c5b000899f5ba
😎 Deploy Preview https://deploy-preview-4073--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4b547839-0085-4b5b-8999-992d341041a7

📥 Commits

Reviewing files that changed from the base of the PR and between ffc2626 and 3a77d5b.

📒 Files selected for processing (1)
  • src/components/Maintainers.astro
💤 Files with no reviewable changes (1)
  • src/components/Maintainers.astro

Walkthrough

Updated project to Astro v6 and bumped related Starlight/Astro devDependencies. Switched several blog author avatar URLs to GitHub’s avatars.githubusercontent.com format. Removed the Vite alias mapping @./src. Enabled experimental.queuedRendering with contentCache: true and poolSize: 2000. Changed Zod import from astro:content to astro/zod. Made many internal imports explicit by adding .ts extensions. Reworked src/content/team.json shape (string usernames → numeric ids) and adjusted avatar/component code to use the new member.id field.

Possibly related PRs

Suggested reviewers

  • arendjr
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ❓ Inconclusive Changes include necessary configuration adjustments (avatar URLs, import paths, schema updates) and team membership updates that appear related to the Astro upgrade, though some changes like avatar URL restructuring warrant clarification. Verify that avatar URL changes and team.json restructuring are necessary consequences of the Astro v6 upgrade, or confirm they are intentional companion changes.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: upgrading Astro to v6, which aligns with the primary objective of the pull request.
Description check ✅ Passed The description references the linked issue (#4070) and is related to the changeset, though minimal in detail. It adequately conveys that this PR addresses the Astro v6 upgrade.
Linked Issues check ✅ Passed The PR successfully upgrades Astro from v5.16.15 to v6.0.8 and related dependencies, addressing the core requirement of issue #4070 to upgrade Astro to v6.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/upgrade-astro-v6

Comment @coderabbitai help to get the list of available commands and usage tips.

@ematipico ematipico force-pushed the chore/upgrade-astro-v6 branch from 58f91c8 to 2227ef2 Compare March 23, 2026 08:09
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/components/GitHubAvatar.astro`:
- Around line 14-15: The avatar image URL in src/components/GitHubAvatar.astro
uses avatars.githubusercontent.com (see the image template variable using
member.data.id), but that hostname is not included in the Astro image allowlist;
update the Astro config's image.domains array (the domains list in
astro.config.ts) to add "avatars.githubusercontent.com" alongside "github.com",
"raw.githubusercontent.com" and "img.shields.io" so Astro can optimise the
avatar images referenced by the image variable in GitHubAvatar.astro.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a8a9b360-ee63-4daf-b5b0-e879c80bdd7b

📥 Commits

Reviewing files that changed from the base of the PR and between 3984220 and ffc2626.

📒 Files selected for processing (4)
  • src/components/Avatar.astro
  • src/components/GitHubAvatar.astro
  • src/content.config.ts
  • src/content/team.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/content.config.ts

Comment on lines +14 to +15
const url = `https://github.com/${member.id}`;
const image = `https://avatars.githubusercontent.com/u/${member.data.id}?v=4&s=200`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

fd -HI '^astro\.config\.(mjs|mts|ts|js|cjs)$' -t f | while read -r file; do
  echo "== $file =="
  rg -n 'avatars\.githubusercontent\.com|image\s*:|remotePatterns|domains' "$file" || true
done

Repository: biomejs/website

Length of output: 589


Add avatars.githubusercontent.com to Astro image domains allowlist.

The code uses avatars.githubusercontent.com for avatar images, but it's missing from the domains array in astro.config.ts (line 1037). Add it alongside the other GitHub domains to enable image optimisation.

Allowlist fix location
image: {
	domains: ["github.com", "raw.githubusercontent.com", "avatars.githubusercontent.com", "img.shields.io"],
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/components/GitHubAvatar.astro` around lines 14 - 15, The avatar image URL
in src/components/GitHubAvatar.astro uses avatars.githubusercontent.com (see the
image template variable using member.data.id), but that hostname is not included
in the Astro image allowlist; update the Astro config's image.domains array (the
domains list in astro.config.ts) to add "avatars.githubusercontent.com"
alongside "github.com", "raw.githubusercontent.com" and "img.shields.io" so
Astro can optimise the avatar images referenced by the image variable in
GitHubAvatar.astro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Astro to v6

1 participant