Skip to content

Fix and test containers#1067

Merged
ColmTalbot merged 5 commits intomainfrom
fix-and-test-containers
Apr 2, 2026
Merged

Fix and test containers#1067
ColmTalbot merged 5 commits intomainfrom
fix-and-test-containers

Conversation

@ColmTalbot
Copy link
Copy Markdown
Collaborator

The CI tests are pretty broken again. I'm not sure if this is due to changes I made or not.

I added some tests to the containers between building and pushing them, so hopefully we won't have broken containers being pushed in the future.

Summary of changes:

  • the dockerfile gets SETUPTOOLS_SCM_IGNORE_DUBIOUS_OWNER=1. This tells setuptools_scm to ignore the fact that it is being run in a repository the user doesn't own.
  • the containers are stored to local storage after being built.
  • these local containers run the basic tests (imports and entry points).
  • if these tests pass, the last stage uploads the containers to the registry.

I don't understand why the user doesn't own the repository anymore, but this fixes the problem at least.

As usual, if this isn't merged by midnight the old container will be rebuilt and things will start breaking again.

I also reactivated the tests that our command line entry points work.

@ColmTalbot ColmTalbot requested a review from a team April 1, 2026 20:52
@ColmTalbot ColmTalbot enabled auto-merge April 1, 2026 20:55
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.24%. Comparing base (cde65c5) to head (8ad24e9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1067   +/-   ##
=======================================
  Coverage   66.24%   66.24%           
=======================================
  Files          89       89           
  Lines       17064    17064           
  Branches     2642     2642           
=======================================
  Hits        11304    11304           
  Misses       5021     5021           
  Partials      739      739           
Flag Coverage Δ
python310 66.03% <ø> (-0.05%) ⬇️
python311 66.24% <ø> (+0.03%) ⬆️
python312 66.19% <ø> (-0.05%) ⬇️
python313 66.19% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ColmTalbot
Copy link
Copy Markdown
Collaborator Author

The latest jobs are failing because:

  • the py310 container doesn't contain the setuptools fix. I think this means it is not to do with a change in the build as we haven't rebuilt this container for a while.
  • python312+ is using arviz=1 which chnaged the API pretty heavily. I'm going to pin that in the environment file.

Copy link
Copy Markdown
Collaborator

@GregoryAshton GregoryAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read over the MR and it looks good to me.

@ColmTalbot ColmTalbot requested a review from a team April 2, 2026 14:26
@ColmTalbot ColmTalbot added this pull request to the merge queue Apr 2, 2026
Merged via the queue into main with commit 5610788 Apr 2, 2026
31 of 35 checks passed
@ColmTalbot ColmTalbot deleted the fix-and-test-containers branch April 2, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants