[BUG] Fix the rescaling of subsets of ConditionalPriorDict and streamline subset resolving#1025
Open
JasperMartins wants to merge 5 commits intobilby-dev:mainfrom
Open
[BUG] Fix the rescaling of subsets of ConditionalPriorDict and streamline subset resolving#1025JasperMartins wants to merge 5 commits intobilby-dev:mainfrom
ConditionalPriorDict and streamline subset resolving#1025JasperMartins wants to merge 5 commits intobilby-dev:mainfrom
Conversation
… a PriorDict copy everytime)
…/sample/rescale/cdf
…keys not recognized
JasperMartins
force-pushed
the
fix-rescale-subset
branch
from
4f1bd58 to
c08a9a0
Compare
Contributor
Author
|
Just a rebase to the current main :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses Item 3 in #1026
To reiterate, current issues for rescaling/sampling/evaluating subsets of keys are:
ConditionalBetaDistributionas a "fixed" prior and add it to any prior evaluation, which could lead to wrong results.This PR addresses these issues and streamlines subset-resolving.