Open
Conversation
j05h
approved these changes
Aug 20, 2021
Member
Author
|
Holding on this for a bit until we're sure we want to adopt RBS as-is. |
TomA-R
approved these changes
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? Why?
Adds .rbs files for type checking support for Ruby 3+.
Note we're not implementing Steep or other static checkers yet as libraries Gruf depends on are not yet fully RBS-supported.
How was it tested?
rspec, rubocop, and through an IDE (such as RubyMine) that has native RBS support.
@bigcommerce/ruby