feat: enables client-side navigation in Makeswift builder#2913
feat: enables client-side navigation in Makeswift builder#2913agurtovoy wants to merge 1 commit intointegrations/makeswiftfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
| "@conform-to/zod": "^1.6.1", | ||
| "@icons-pack/react-simple-icons": "^11.2.0", | ||
| "@makeswift/runtime": "^0.26.0", | ||
| "@makeswift/runtime": "https://pkg.pr.new/makeswift/makeswift/@makeswift/runtime@1259", |
There was a problem hiding this comment.
This needs to be changed to a released runtime version before we can merge this PR.
There was a problem hiding this comment.
I also think we need Next 16 + React 19 in order to merge a new runtime version as well. @matthewvolk is tackling this right now.
There was a problem hiding this comment.
The new runtime version should still work with Next 15 + React 18. The runtime uses Suspense instead of Activity when it's on React 18.
There was a problem hiding this comment.
@chanceaclark Just to clarify, we don't have to upgrade to Next 16 + React 19 at the same time; Makeswift runtime still supports React 18 and older Next.js versions all the way down to 13.4, so we can tackle the Next 16/React 19 upgrade to get the <Activity> performance improvements independently of upgrading Makeswift runtime to pull in other features/bug fixes.
There was a problem hiding this comment.
Interesting 🤔 I've been going with the assumption that it's hand-in-hand, specifically to fix that performance issue with <Activity />. TIL that we should be good then.
There was a problem hiding this comment.
Yep, we need runtime@0.26.3+, Next 16, and React 19 to get the <Activity /> performance improvements, but otherwise, these are not coupled. If we want to, we can upgrade to runtime@0.26.3 right now without forcing the Next 16 / React 19 upgrade.
Enabled by upgrading to the latest Makeswift runtime
agurtovoy
force-pushed
the
aleksey/makeswift-builder-client-side-navigation
branch
from
4f1d31a to
22c8123
Compare
jorgemoya
left a comment
jorgemoya
left a comment
There was a problem hiding this comment.
Should we include a changeset?
|
Tagging with Edit: nevermind, it's a draft PR 🤦 |
4 participants
What/Why?
Enables client-side navigation in Makeswift builder by upgrading Catalyst to the latest Makeswift runtime.
Testing
Migration