enhancement: currency type are now decimal#11
Open
leo-tavares wants to merge 1 commit intobhrugen:masterfrom
Open
enhancement: currency type are now decimal#11leo-tavares wants to merge 1 commit intobhrugen:masterfrom
leo-tavares wants to merge 1 commit intobhrugen:masterfrom
Conversation
Replace currency type from double to decimal and add a new migration Models affected - OrderDerail - OrderHeader - Product - ShoppingCart=
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr;
Replace currency type from double to decimal and add a new migration
Models affected
Reason
On this doc decimal datatype are appropriate for financial calculations.
Even though it's an educational application, I believe it's highly valuable to utilize data types that are commonly used in production environments