fix: skip settings on codeDiff if does not exisits#26
Merged
Conversation
sakulstra
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some explorers do not have settings param on the downloaded source code, for ex. x-layer explorer does not, which at the moment causes code diffs to break.
This patch allows to still perform codeDiffs via CLI if settings does not exists on the source code from the explorer. So we skip doing diffs on the settings if it does not exists.
To test it works, you can try with this command for ex.
node packages/cli/dist/index.js codeDiff --address2 0x061D8e131F26512348ee5FA42e2DF1bA9d6505E9 --chainId2 196 --address1 0x8147b99DF7672A21809c9093E6F6CE1a60F119Bd --chainId1 1 -o file --path ./diffs/POOL.md