Draft
Conversation
(cherry picked from commit 21362ac)
chore: merge updated permit flow
|
defispartan
reviewed
Jan 4, 2023
src/store/v3MigrationSelectors.ts
Outdated
| const selectedReserve = v3ReservesMap[userReserve.underlyingAsset]?.reserve; | ||
|
|
||
| if (isolatedReserveV3) { | ||
| disabledForMigration = selectedReserve.borrowableInIsolation; |
There was a problem hiding this comment.
Should be negated, !selectedReserve.borrowableInIsolation
defispartan
reviewed
Jan 4, 2023
src/store/v3MigrationSelectors.ts
Outdated
|
|
||
| if (isolatedReserveV3) { | ||
| disabledForMigration = selectedReserve.borrowableInIsolation; | ||
| } else if (userEmodeCategoryId !== 0) { |
There was a problem hiding this comment.
Currently this won't handle if a user is in eMode and isolationMode. To fix this you can replace the else if with if(!disabledForMigration && userEmodeCategoryId !== 0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft of beginning migration UI to discuss multiple permits.
My initial idea was