Skip to content

Remove cmake and dummy.cpp in Android example#23548

Merged
mockersf merged 2 commits intobevyengine:mainfrom
beicause:android-cmake
Mar 28, 2026
Merged

Remove cmake and dummy.cpp in Android example#23548
mockersf merged 2 commits intobevyengine:mainfrom
beicause:android-cmake

Conversation

@beicause
Copy link
Copy Markdown
Contributor

Objective

libc++_shared.so is no longer needed after #20323

Solution

Remove unused dummy.cpp and cmake in Android examples.

Testing

Run:

cargo ndk -P 26 -t arm64-v8a build -o examples/mobile/android_example/app/src/main/jniLibs -p bevy_mobile_example
cd examples/mobile/android_example
./gradlew assembleDebug
adb install -r ./app/build/outputs/apk/debug/app-debug.apk

@mockersf mockersf added the O-Android Specific to the Android mobile operating system label Mar 28, 2026
@mockersf mockersf added this to the 0.19 milestone Mar 28, 2026
leomeinel added a commit to leomeinel/bevy that referenced this pull request Mar 28, 2026
Copy link
Copy Markdown
Contributor

@leomeinel leomeinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome and works pretty well. Except the pending comments I approve. Similar changes have been tested as part of #23491 and it built and ran fine after reverting #23379.

@JMS55 JMS55 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 28, 2026
@mockersf mockersf added this pull request to the merge queue Mar 28, 2026
Merged via the queue into bevyengine:main with commit d29347b Mar 28, 2026
40 checks passed
@beicause beicause deleted the android-cmake branch March 28, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-Android Specific to the Android mobile operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants