Add support for an "authors" collection#1
Open
tosky wants to merge 1 commit intobeta-europe:masterfrom
Open
Conversation
CKroes97
reviewed
Apr 26, 2021
Contributor
CKroes97
left a comment
CKroes97
left a comment
There was a problem hiding this comment.
I left two comments, looks good for the rest
config.yml
Outdated
| - name: "authors" | ||
| label: "Authors" | ||
| folder: "_authors/" | ||
| slug: "{{name}}" |
Contributor
There was a problem hiding this comment.
Using the name as a slug is bad practice since people can have the same first and -last name
Author
There was a problem hiding this comment.
Uh, right, I guess {{ title }} is enough?
| - {label: "Image", name: "image", widget: "image", required: false} | ||
| - {label: "Thumbnail for Partner Overview", name: "teaser", widget: "image", required: false} | ||
| - {label: "Label (e.g. for credit)", name: "credit", widget: "string", required: false} | ||
| - name: "authors" |
Contributor
There was a problem hiding this comment.
You might want to wrap this in an "{% if site.cms.has_members %}{% raw %}
//your code
{% endraw %}
Author
There was a problem hiding this comment.
Shouldn't this be always enabled? Otherwise the link inside the "posts" collection can be broken
Handled through the admin UI, it is primarily used to assign authors to articles. It may be extended to support additional use cases (for example team members data).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handled through the admin UI, it is primarily used
to assign authors to articles.
It may be extended to support additional use cases
(for example team members data).