feat(security): add HMAC authentication for gRPC server#145
Open
kwsantiago wants to merge 1 commit intobennyhodl:masterfrom
Open
feat(security): add HMAC authentication for gRPC server#145kwsantiago wants to merge 1 commit intobennyhodl:masterfrom
kwsantiago wants to merge 1 commit intobennyhodl:masterfrom
Conversation
kwsantiago
force-pushed
the
138-grpc-auth
branch
2 times, most recently
from
d730480 to
ac1678e
Compare
Owner
|
We should probably have authentication that doesn't just check a string but verifies a signature. Or an API secret that the server can generate as an API key to verify in request
|
kwsantiago
force-pushed
the
138-grpc-auth
branch
from
ac1678e to
709162e
Compare
kwsantiago
changed the title
Contributor
Author
|
@bennyhodl good point, thank you for pointing out. Reflected in 709162e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #138