lastgenre: Apply canonicalization to genres of items with no Last.fm results#6383
Open
Bergbok wants to merge 4 commits intobeetbox:masterfrom
Open
lastgenre: Apply canonicalization to genres of items with no Last.fm results#6383Bergbok wants to merge 4 commits intobeetbox:masterfrom
Bergbok wants to merge 4 commits intobeetbox:masterfrom
Conversation
1061f9d to
c08f473
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6383 +/- ##
==========================================
+ Coverage 68.96% 68.97% +0.01%
==========================================
Files 140 140
Lines 18685 18683 -2
Branches 3056 3055 -1
==========================================
+ Hits 12886 12887 +1
+ Misses 5155 5154 -1
+ Partials 644 642 -2
🚀 New features to boost your workflow:
|
c08f473 to
67f7658
Compare
Member
A blacklist feature is in the pipeline but it will take a while until it's ready. 2 other lastgenre PR's need to go first. You could test from the branch but I suggest with a test library setup only for now: #5744 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been configuring my canonicalization tree to remove tags I don't like, essentially using it like a blacklist, and noticed some tags not being removed after re-running the lastgenre command.
The reason for this is that when
keep_existingis enabled and no Last.fm results are found, the existing genres are returned as-is without being processed through_resolve_genres(). This means existing genres that should be filtered by the canonicalization tree are kept unchanged.As an example, if I had this in my canonicalization tree:
and then ran lastgenre on a track with 'some tag', but which had no data on Last.fm, it wouldn't get removed from the track. This PR fixes that.