fix: ftintitle can handle a list of ampersanded artists#6375
Open
fredrik wants to merge 1 commit intobeetbox:masterfrom
Open
fix: ftintitle can handle a list of ampersanded artists#6375fredrik wants to merge 1 commit intobeetbox:masterfrom
fredrik wants to merge 1 commit intobeetbox:masterfrom
Conversation
fredrik
force-pushed
the
ftintitle-multiple-ampersanded-artists
branch
from
5b93cde to
a2d1cd1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6375 +/- ##
=======================================
Coverage 69.18% 69.18%
=======================================
Files 140 140
Lines 18686 18689 +3
Branches 3053 3054 +1
=======================================
+ Hits 12927 12930 +3
Misses 5114 5114
Partials 645 645
🚀 New features to boost your workflow:
|
fredrik
force-pushed
the
ftintitle-multiple-ampersanded-artists
branch
from
a2d1cd1 to
0b12e9f
Compare
Member
|
Just needs rebasing on master to resolve the conflict in the changelog. |
fredrik
force-pushed
the
ftintitle-multiple-ampersanded-artists
branch
from
0b12e9f to
354d24a
Compare
This was inspired by real life events: https://musicbrainz.org/release/7c4d7a15-6b30-4bef-8b20-af200186fbdb by the artist Danny L Harle has a a track with a featuring list that contains "Danny L Harle, Oklou & MNEK".
fredrik
force-pushed
the
ftintitle-multiple-ampersanded-artists
branch
from
354d24a to
4fa3e53
Compare
Contributor
Author
Done! The unrelated windows test failures are also green now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This was inspired by real life events:
https://musicbrainz.org/release/7c4d7a15-6b30-4bef-8b20-af200186fbdb by the artist Danny L Harle has a a track with a featuring list that contains "Danny L Harle, Oklou & MNEK".
Before:
After: