thumbnail border broken when deadbeat#749
Open
krugerk wants to merge 1 commit intobeeminder:masterfrom
Open
Conversation
border was being set when clearing the graph, just on setting it (to a non-placeholder), and that was not being called when deadbeat
krugerk
changed the title
krugerk
commented
Mar 10, 2026
| self?.imageView.layer.borderColor = nil | ||
| self?.imageView.layer.borderWidth = 0 | ||
| } | ||
| self?.updateBorder() |
Contributor
Author
There was a problem hiding this comment.
not impressed about having to (remember to) call this at two places ... might refactor it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GoalImageView calculated and set the border once a non-placeholder thumbnail was set.
When isDeadbeat, the thumbnail was replaced by the placeholder and the border was not being addressed (neither cleared nor set anew).