splitting up healthkitmetrics for maintainability#741
Open
krugerk wants to merge 2 commits intobeeminder:masterfrom
Open
splitting up healthkitmetrics for maintainability#741krugerk wants to merge 2 commits intobeeminder:masterfrom
krugerk wants to merge 2 commits intobeeminder:masterfrom
Conversation
theospears
reviewed
Feb 23, 2026
| import HealthKit | ||
|
|
||
| public class ActivityHealthKitMetrics { | ||
| public static let shared = ActivityHealthKitMetrics() |
Collaborator
There was a problem hiding this comment.
What is gained by making all of these singletons rather than just using statics. They seem like read only configuration constants.
Contributor
Author
There was a problem hiding this comment.
It was just one shot at how else these things might be organized. Rather than the single long list of before there are now several, mostly shorter, lists.
They are also all now implemented as lazy var, though the big list from before could have been as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
split the long list up for easier oversight